[Bug 30478] Add TP_ACCOUNT_FEATURE_STORAGE to TpAccount

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30478

--- Comment #7 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2010-10-06 17:28:09 PDT ---
> >    if (error != NULL)
> > -    {
> > -      DEBUG ("Error getting Storage properties: %s", error->message);
> > -      _tp_proxy_set_feature_prepared (proxy, TP_ACCOUNT_FEATURE_STORAGE,
> > -          FALSE);
> > -      return;
> > -    }
> > +    DEBUG ("Error getting Storage properties: %s", error->message);
> 
> Removing the early return looks wrong: properties will be NULL and all the
> accesses to it will (either g_critical() or) crash. Did you test this case?

Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.