[Bug 26590] GetFrequentContacts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26590

--- Comment #10 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-07 06:05:44 PDT ---
(In reply to comment #9)
> > Including chatrooms in the result of a function called Get_Recent_*Contacts*
> > seems bong to me. What's the use case for this?
> > Same for GetFrequentContacts
> 
> Suggestions for new names?

Do we really need chat rooms tbh? If we do I'd be tempted we should either have
a GetFrequentChatrooms() or express the API in term of TpHandleType.

> >       /* we assume that the AM is ready */
> > Ideally,  TplDBusService should have a priv->account_mgr and not be registered
> > until it has been prepared so we don't have to check if features are prepared
> > and just assert they are.
> 
> Should I take out the check then?

Well, if you do the suggested refactoring, yes :)

> > _tpl_get_tp_account()
> > why not use tp_account_manager_ensure_account() so we reuse existing TpAccount?
> 
> If someone passes a made-up account path it will create that object on the bus?
> I want it to error instead.

Humm, maybe we should have a tp_account_manager_get_account() ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.