[Bug 30430] Make wocky_implement_finish_* macros safer

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Oct 7 22:16:14 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30430

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/nicolas/wocky.git;a |?p=user/nicolas/wocky.git;a
                   |=shortlog;h=refs/heads/fini |=shortlog;h=refs/heads/fini
                   |sh                          |sh2

--- Comment #8 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-10-07 13:16:14 PDT ---
(In reply to comment #7)
> If GLib upstream are basically saying "g_simple_async_report_error_in_idle is
> never right" then I suppose we can do this... but which of the situations in
> comment #4 is actually a problem?

The problem is more conceptual then real. So I've reworked the patch set to
keep the call order, fixing the macro and the Cancellable ref.

Here's the new branch:

http://git.collabora.co.uk/?p=user/nicolas/wocky.git;a=shortlog;h=refs/heads/finish2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list