[Bug 30430] Make wocky_implement_finish_* macros safer

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Oct 7 22:19:42 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=30430

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39017|0                           |1
        is obsolete|                            |
  Attachment #39020|0                           |1
        is obsolete|                            |

--- Comment #10 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-10-07 13:19:41 PDT ---
Created an attachment (id=39267)
 View: https://bugs.freedesktop.org/attachment.cgi?id=39267
 Review: https://bugs.freedesktop.org/review?bug=30430&attachment=39267

Fix wocky_implement_finish_*() macro

* Fixed missing scope (G_STMT_START/G_STMT_END) and missing parenthesis
* Don't call copy_func if the result is NULL (enabling use of g_object_ref
  as copy_func).
* Added missing ; now required when those macro are called.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list