[Bug 31001] channel client factory: add API for TpChannel preparation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31001

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review-, minor changes
         AssignedTo|telepathy-bugs at lists.freede |guillaume.desmottes at collabo
                   |sktop.org                   |ra.co.uk

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-21 06:11:18 PDT ---
> + * Once a channel has be created by a factory using

has been created

> + * Returns: (transfer container): a newly allocated #GArray

I think containers of integers are usually said to be "transfer full", since
for non-freeable contents it's equivalent to "transfer container" anyway, and
"full" is simpler to explain.

I think the name should say _dup_ (and the same for the underlying virtual
method).

> +array_contain_feature (GArray *features,

array_contains_feature, and @features should be const

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.