[Bug 29377] Implement Channel.Interface.Messages

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29377

--- Comment #8 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-27 07:38:57 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > test-message.py doesn't pass any more because ListPendingMessages() now returns
> > a delivery report. Is that expected?
> 
> That sounds okay to me.

Cool, I changed the test then.


(In reply to comment #6)
> (In reply to comment #4)
> > Here is a first version:
> > http://git.collabora.co.uk/?p=user/cassidy/telepathy-sofiasip;a=shortlog;h=refs/heads/messages-29377
> 
> +  if (content_type == NULL || tp_strdiff (content_type, "text/plain"))
> 
> Do we get the "content-type" value normalized? If not, this should be a
> case-insensitive check.

I think so; that's how it's done in all the other CM.

> I should perhaps add extraction of "message-sent" and an appropriate unique
> token from SIP headers, in a follow-up change.

Please feel free :)


(In reply to comment #7)
> http://git.collabora.co.uk/?p=user/cassidy/telepathy-sofiasip;a=commitdiff;h=a5a7b7909152cde4d7f575ab88ddb41fb3cb3fb5
> 
> This part looks fine, except I can't see where the delivery token is exposed in
> the sent message.

That's the 4th argument of tp_message_mixin_sent(). My patch was wrongly
recorded; it should be clearer now:
http://git.collabora.co.uk/?p=user/cassidy/telepathy-sofiasip;a=commitdiff;h=13285043020ed6bdaa72b30bf65ac9b7d6b0207e

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.