[Bug 29531] high-level API for text channels

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29531

--- Comment #10 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-10-29 02:24:40 PDT ---
(In reply to comment #9)
> This looks as though it's on the right track.
> 
> > void tp_text_channel_forget (TpTextChannel *self,
> >     GList *messages, /* list of TpMessage */);
> > 
> > and maybe a forget_all() ?
> 
> This is for Observers/Approvers to use, in situations where a Handler would
> acknowledge the message; in the Messages-not-mandatory world, you can't rely on
> being told about message acknowledgement. I'd be inclined to just press onwards
> with implementing Messages and stop caring about this case; the version of
> Empathy/Tpl/whatever that requires Messages can have a versioned Breaks on
> older CMs.
>

Agreed.

> > Actually I'm wondering if that's not overkill and we should just give the
> > token in tp_text_channel_send_message_finish() and let the user do the
> > delivery-report mapping itself if it cares.
> 
> I agree, do that, precisely because we can't guarantee we'll ever be notified.

done.

> > add example_echo_2_channel_get_props()
> 
> Should never be necessary. Use TpExportableChannel:immutable-properties
> instead; if there are properties missing (perhaps the three from Messages), add
> them.

Done.
I guess
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=commitdiff;h=508af359ff78b4a5d8ea0d722ec2d046f9c4a9df
can be cherry picked and merged.

> > +      const GHashTable *part = tp_message_peek (msg, 1);
> > +      const gchar *text = tp_asv_get_string (part, "content");
> 
> We should have convenience API tp_message_get_text() for this, but it should
> basically be parts_to_text() from message-mixin.c (which deals with more
> subtleties, including the possibility of non-text content).

Ok, I'll add that to the message client branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.