[Bug 31211] telepathy-yell: temporary submodule for draft Call implementations

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 29 13:29:14 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=31211

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-29 04:29:14 PDT ---
COPYING talks about librtcom-telepathy-glib, which is wrong, and mentions a
Nokia copyright, which is probably wrong.

> AM_INIT_AUTOMAKE([1.9 -Wall -Wno-portability foreign])

This one goes to 11 (or should). We never test it with 1.9 anyway, and it
wouldn't work (you used AM_SILENT_RULES unconditionally). You'll need to change
autogen.sh too.

> PKG_CHECK_MODULES(GLIB, [glib-2.0 >= 2.25.16, gobject-2.0 >= 2.25.16])

I'd be inclined to say 2.26 for clarity.

> PKG_CHECK_MODULES(TP_GLIB, [telepathy-glib >= 0.7.18])

Do we really interop with such an old version? I'd be inclined to say 0.12 if
it works, or whatever version is actually needed otherwise.

> if ENABLE_SHARED_LIBRARY
> lib_LTLIBRARIES = libtelepathy-yell.la

I think this should have -release in its LDFLAGS in the shared case, leading to
libtelepathy-yell.la and libtelepathy-yell-0.1.2.so or something.

Indeed, we could do something like this:

# static-only embedding
./configure

# yields libtelepathy-yell-gabble-0.11.4.so, via
#     libtool --mode=link -release $(LIBRARY_SUFFIX) ...
./configure --enable-library-suffix=gabble-0.11.4

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list