[Bug 31200] Windows portability patches for telepathy-qt4

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31200

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-29 05:28:08 PDT ---
Review of attachment 39859:
 --> (https://bugs.freedesktop.org/review?bug=31200&attachment=39859)

::: TelepathyQt4/capabilities-base.cpp
@@ -161,3 @@
     uint targetHandleType;
     foreach (const RequestableChannelClass &cls, mPriv->classes) {
-        if (!cls.fixedProperties.size() == 2) {

This looks like a real bug, in fact; the precedence isn't what the author of
this code expected.

The fix should be "if (blahblah.size() != 2)", though :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.