[Bug 28199] port Gabble to TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28199

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-03 07:39:26 PDT ---
(In reply to comment #6)
> * the test coverage is rather patchy
> 
> * contacts can now be removed while not on the list, Unpublish()d while already
> publish=No, etc., and Gabble will probably do the wrong thing in many of those
> cases (the Group API wouldn't have allowed this situation to arise)

I now have regression tests for many no-op changes, and have fixed some bad
assumptions.

I've also made the roster code distinguish between people who we *treat as* on
the roster, and people who *are* on the roster (a subset), which is a bit scary
but more correct.

(People from whom we have received a publish request are treated as if on the
roster, without actually being there. Technically, that means they shouldn't be
on 'stored', but in practice we never did that and I don't think anyone really
wants that semantic.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.