[Bug 30000] Trial implementation of SucceededWithChannel, CreateChannelWithHints

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30000

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-03 09:06:56 PDT ---
Next steps here are (quoting cassidy and myself from
<https://bugs.freedesktop.org/show_bug.cgi?id=28866#c10>):

> I fixed this one (not sure if that's the best way, this code looks like a bit
> like a can of worms to me tbh :\ )

This code *is* a can of worms :-( See smcv/wip-req-export, in which I tried to
split McdChannel into the bits that are really a channel and the bits that are
a channel request, and have the latter be exported as the ChannelRequest; in
particular, the top commit, which is called "WiP: doesn't work" and is
something like my 5th attempt at it.

Your code changes look good, except for the last commit where I need to read
the code a bit more to work out wtf is going on. I suspect that what you did is
necessary and correct, even though it makes little sense.

Would you mind if I pick up this branch and make it use an in-tree extension
instead of the patched telepathy-glib you're presumably using, so we can merge
it before undrafting the spec, and continue to refactor?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.