[Bug 30065] Port Gabble to undrafted ContactSearch

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30065

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ with minor changes

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-08 03:53:51 PDT ---
> +    assertEquals(results.keys(), infos.keys())

I think this assumes they'll fall out of the dict in the same order, which
isn't a Python API guarantee. I'd prefer to compare set(results.keys()) with
set(infos.keys()) to be sure it'll keep working.

(Four occurrences, including one in unextended.py.)

Other than that, review+

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.