[Bug 29981] Support power saving interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29981

--- Comment #12 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-09-15 11:48:27 PDT ---
(In reply to comment #10)
> (In reply to comment #7)
> > I see Conn.I.PowerSaving being useful for offline connections as well, but I am
> > not totally convinced about it. You could sway me either way. If we use this
> > iface on offline accounts, we don't need to piggyback on top of google:roster,
> > we will just always sport the iface, and raise NotAvailable if the service does
> > not support it. Added bonus - non-google servers could support google:queue and
> > we would interop with them, even if they don't support google:roster.
> 
> I would make it raise NotAvailable() until Connected, using
> TP_BASE_CONNECTION_ERROR_IF_NOT_CONNECTED(). When we get the server features,
> check for 'google:queue' or 'google:roster'; if either is present, add the
> interface using tp_base_connection_add_interfaces().
> 

Great! Made the appropriate changes. 0545f7c

> By checking for both features we would do the right thing with the deployed
> server that implements this feature, and allow for hypothetical servers to do
> the right thing.

This introduces false positives when a server genuinely supports google:roster,
but not google:queue. This is all hypothetical, so never mind :)

> 
> This would mean MC should check for this interface only once the connection is
> connected. That seems fine: we can't exactly save power during the connection
> process. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.