[Bug 29298] review Conn.I.ClientTypes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29298

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |r+

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-09-20 03:58:51 PDT ---
       const gchar *type;

       /* Now get the client type */
-      if ((type = wocky_node_get_attribute (identity, "type")) == NULL)
+      type = wocky_node_get_attribute (identity, "type");

You could assign to 'type' when you declare it.

+      if(type == NULL)

Style: space before paren.

Ah I see you made both of these comments unnecessarily later.

+      if (g_ptr_array_index (types, 0) != NULL)

Is this secret code for (types->len > 0)? If not, could you explain why not?
It's not obvious to me.

The Android special case is pretty annoying, but it seems like a reasonable
compromise. We should also nag Google to do the right thing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.