[Bug 29077] refactor the roster, moving logic out of the channels into the roster itself

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29077

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ with trivia

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2010-09-22 06:42:36 PDT ---
Test deleting contact lists via Close()

Is this change merged back to the corresponding test in Gabble?

+    bus.get_object(conn.bus_name, '/').Ping()

sync_dbus?

haze_contact_list_add_to_group() uses:

+    PurpleGroup *group = purple_group_new (group_name);

which is actually kosher, because _new() returns an existing group if possible.
It threw me a bit, though. Guess I've been away too long. Any chance of a
comment explaining that this is correct?

Otherwise looks fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.