[Bug 30347] Various build fixes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30347

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|telepathy-bugs at lists.freede |simon.mcvittie at collabora.co
                   |sktop.org                   |.uk

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-24 03:18:21 PDT ---
Assigning to myself to review/check this, since I seem to be the department of
portability.

We may be able to fix some of this by syncing code from telepathy-gabble -
could you please try building Gabble 0.10.0 and confirm whether that works on
OpenBSD?

(For context: Gibber was a prototype GLib network/XMPP library shared by Gabble
and Salut. We pushed many of the network bits into GIO instead; the XMPP bits
became Wocky, which is currently part of Gabble but will become a separate
library when it's more stable. Our long-term plan is to migrate everything into
GIO or Wocky as appropriate, then delete what's left of Gibber.)

(In reply to comment #0)
> - Include the right headers needed, at the right location (system headers
> before uerland headers)

Hopefully this won't break any other Unixes in the process... I'll need to
check autoconf.info before merging this, but in principle it seems OK.

> - Locally define SCM_CREDENTIALS and SO_PASSCRED. This is rather ugly, and I'm
> not even sure this actually works. Any idea?

Sorry, I'm not going to accept patches that #define random system constants;
surely there must be a system header that provides these?

The equivalent code in Gabble just disables credentials-passing in the library
code on non-Linux OSs (!defined(__linux__)), then copes with that omission in
src/. As a first step to make this compile on OpenBSD, we should do that.

After that, the next step would be to implement credentials-passing for *BSD
too. The way forward for that would probably be to make sure it's implemented
in GIO (which I believe currently supports it on at least Linux and FreeBSD -
does OpenBSD work the same as one of those?), then use the appropriate GIO API
on all OSs. Failing that, we could also include code derived from what's in
GIO.

> - OpenBSD's ucred structure doesn't have a pid member.

Including a dummy pid (0 or -1 perhaps) seems safer than the CM's own pid. I
don't think Gabble or Salut actually use the pid anyway, so we could just
remove it from the Gibber API.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.