[Bug 29218] TpStreamTube - high level stream tube API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29218

--- Comment #27 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-09-24 09:44:23 PDT ---
(In reply to comment #26)
> (In reply to comment #25)
> > Anyone feel like proposing Wocky's macros for glib?
> 
> I'll have a look into it, this should not block this review though, most
> sources implements _finish() manually.

Actually those calls have issues that may prevent them from being included.

1. It's wrong to call g_simple_async_result_propagate_error() before
g_simple_async_result_is_valid()
2. A copy_func may not support NULL (e.g. g_object_ref), use case found in 
g_socket_address_enumerator_next_finish().

Aside those, I don't see any major issues. I'll propose a fix to Wocky before
trying to get those into GLib.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.