[Bug 30398] incorporate OpenBSD patches or make them unnecessary

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30398

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-27 09:39:01 PDT ---
(In reply to comment #1)
> Our gcc4 would error out with -Wall about missing sentinel in function call.
> This fixes it.

I don't think this is appropriate to apply, then; info gcc says:

     A valid `NULL' in this context is defined as zero with any pointer
     type.  If your system defines the `NULL' macro with an integer type
     then you need to add an explicit cast.  GCC replaces `stddef.h'
     with a copy that redefines NULL appropriately.

so if OpenBSD's gcc packaging breaks this, please complain to your gcc
maintainer.

> > pkg-config
> We wrote our own pkg-config in perl and it resides in the base system. We could
> change it to provide such a file.

If you really can't use the normal pkg-config then you should make sure your
reimplementation is compatible, I think. In the C implementation, there is
actually no pkg-config.pc - pkg-config inserts equivalent information into its
internal data structures before reading any .pc files. I'd recommend doing the
same.

Note that the 0.21 dependency is to support a fairly subtle feature of
Requires.private (adding private dependencies' CFLAGS), so you may need to
check that your pkg-config reimplementation behaves the same.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.