[Bug 30447] Some 'void' functions return a value

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30447

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-09-29 03:04:22 PDT ---
Fixed in git by applying your patch; it'll be in 5.6.1 and 5.7.0. Thanks!

Solaris CC is behaving according to ISO C99, but unfortunately gcc seems to
allow returning a void expression from a void function (presumably as an
extension), and it doesn't seem to have an option to warn about this.

If you send more patches in future, it'd be ideal if you could either format
them with git format-patch or point us to a git repository we can pull from, so
we can credit you appropriately without inventing a commit message.

> --- a/src/mcd-manager.c
> +++ b/src/mcd-manager.c
> @@ -35,7 +35,6 @@
>   * FIXME
>   */
>  
> -#define _POSIX_C_SOURCE 200112L  /* for strtok_r() */

This isn't really part of the fix for this bug (as far as I can see), but we
don't call strtok_r any more anyway, so I applied it as a separate patch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.