[Bug 29672] Should implement profile support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29672

--- Comment #7 from Olli Salli <ollisal at gmail.com> 2010-09-30 09:25:10 PDT ---
Review of the latest state of the branch:

The latest format support patch makes having a provider and an icon mandatory.
The other elements-turned-attributes are crucial, but I don't think the
provider and - more so - the icon should be mandatory! Well, as the spec still
hasn't been totally agreed on, I guess they could be made mandatory there as
well at any point, but I think we still should fail gracefully in that case.
Making the icon optional probably means that the Account iconName() fallback
for the Account not having an icon set should only use the profile icon if
there is one, otherwise the protocol icon, even if there is a real profile.
(And that this behavior should be documented). Otherwise, this patch is OK.

PendingOperation dontFailOnFirstError patch: ++

Fake profile support: Woo, this actually makes listNames() finally tested by
the unit tests :) However, you could elaborate a bit more on what "fake
profile" and "all protocols" actually means in the feature doc comment - the
latter could be something like "all protocols supported on the installed
connection managers, even if they don't have profile files installed making use
of them", I think. ALSO (more critical): shouldn't you check which CMs are, in
fact, ready in the onCMsReady() loop (if one of them failed for some reason?).

Account::profile()::serviceName() for fake profiles change: Hrm, this is
strictly speaking backwards incompatible, but I don't think anybody depends on
the naming of the *fake* profiles yet. So ++.

Moving utility functions around: ++

++ for merge, but address these first (ask for clarification/open discussion if
needed).

The latest changes in this branch were very cleanly organized, thanks for that!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.