[Bug 34932] Use WockyMetaPorter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34932

--- Comment #9 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-01 08:57:54 PDT ---
im-manager: ignore clique MUC invites and leave for the MUC manager

Why isn't the MUC manager just registering a higher-priority handler (and
returning TRUE), rather than some other unrelated handler having to know
details of Clique?

+      DEBUG ("failed to announce: %s",
+          error != NULL ? error->message : "(no error message)");
+
       tp_base_connection_change_status (
             TP_BASE_CONNECTION (self),
             TP_CONNECTION_STATUS_DISCONNECTED,
             TP_CONNECTION_STATUS_REASON_NETWORK_ERROR);
+
+      if (error != NULL)
+        g_error_free (error);

FYI g_clear_error() is null-safe.

+  if (force_called)
+    tp_base_connection_finish_shutdown (base);

It looks like you're ensuring that finish_shutdown will be called exactly 0 or
2 times, and never once? closed_cb only calls it if disconnect_timer is not 0
... okay, so this is right, in which case why is the variable called
"force_called"? I think it means exactly the opposite.

disco: only delete the request if it hasn't been already done for us

This looks completely wrong to me, I'm sorry to say. As far as I can tell,
you'll *always* leak the SalutDiscoRequest if the cancellable is cancelled,
given this patch.

muc-manager: don't assert on no invite node

This patch looks wrong too. When the handler is registered, the pattern
specifies that the <invite xmlns='...clique'/> element must exist. And the
commit message is not English.

   /* release any references held by the object here */

-  if (self->handle != 0)
-    tp_handle_unref (contact_repo, self->handle);
+  if (self->handle != 0 && self->connection != NULL)
+    {
+      TpHandleRepoIface *contact_repo = tp_base_connection_get_handles
+        ((TpBaseConnection *) self->connection, TP_HANDLE_TYPE_CONTACT);
+      tp_handle_unref (contact_repo, self->handle);
+    }

There's an argument that this code could just go away since tp_handle_unref is
a no-op these days.

+        'nickname': re.sub(r'.*/', '', sys.argv[0]),

OOI, why not os.path.basename()? :þ (no big deal)

+        name += ('-' + re.sub(r'.*/', '', sys.argv[0])[:-3])

this is secret code for os.path.splitext(os.path.basename(sys.argv[0]))[0]


+        if len(self.contact_name) > 63:

Is there really no constant for this in the avahi library?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.