[Bug 33404] Move caps hash stuff to Wocky

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33404

--- Comment #12 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-01 09:16:26 PDT ---
I was sure I'd replied to this. But apparently my reply got lost.

(In reply to comment #11)
> (In reply to comment #10)
> > I don't think this is right, I'm afraid. The XEP says:
> > 
> >   • For each field other than FORM_TYPE:
> >       ‣ Append the value of the "var" attribute, followed by the '<'
> >         character.
> >       ‣ Sort values by the XML character data of the <value/> element.
> >       ‣ For each <value/> element, append the XML character data,
> >         followed by the '<' character.
> > 
> > If WockyDataForm's API doesn't make this possible without contortions, we
> > should make it possible, rather than risking incorrectly calculating the hash
> > (despite having had all the necessary information at some point).
> 
> Okay, so I thought it would be difficult to start supporting all the other
> field types, but it turned out to be fine. Fixed and added a test for booleans.
> 
> One problem I see might be an issue here is that the data form parser treats
> both "true" and "1" as value booleans for TRUE (and the opposite for FALSE),
> but the caps hashing code only gets a GValue back and uses 1 and 0 for TRUE and
> FALSE respectively. We don't get the actual stanza from the data form field so
> can't check the actual value.

Then WockyDataForm should be fixed to give you the actual values.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.