[Bug 30298] shows wrong date for some messages

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Apr 3 19:10:06 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=30298

--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-04-03 10:10:04 PDT ---
Btw thanks for replying back.

(In reply to comment #6)
> Well looking into this problem again I found that the log file mentioned in the
> description seems invalid (or obsolete) - the file name is wrong. Telepathy
> would save the log as 20100518.log despite of the fact, that the timestamp of
> the message is "20100517T23:45:00". So the file name is dependent on timezone,
> which is bad.

I have not made my mind yet on this. I think the original author had in mind
that the user will remember a message to be on a certain day (his local
timezone day). But for ordering reason, and because authors of Logger travel a
lot, it was decided that messages timestamps would me marked as UTC to avoid
potential miss-ordering. It's possible that this is a mistake and that we
should have also stored the message timezone, which would have given Empathy a
maximum of tools to show it the right way.

I think all this is based on the fact that we would like to group the text
messages base on conversation. But that concept of conversation start/stop does
not really exist, you may start it in the morning, disconnect, come back, reply
to your body (but he was off-line), then the next day he saw the message and
replied.

I think anytime we focus on 1 message, we need direct before and after context
to understand, not really a day division.

> 
> Therefore I suggest to fix this issue in the following way:
> 1. Make log file names independent from timezome.
> 2. Apply the approach implemented by the patch above to fix the wrong date in
> Empathy's log viewer.
> 
> Please let me know your opinion and then I'll update the patch.

I think I need to speak with Emilio (who is currently implementing the Log
Viewer redesign, see https://bugzilla.gnome.org/show_bug.cgi?id=619866). Also,
feel free to jump in the discussion, Emilio is pochu on IRC and I'm stormer,
usually hanging on gimp.net #empathy and freenode #telepathy.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list