[Bug 33404] Move caps hash stuff to Wocky

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 4 14:29:03 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33404

--- Comment #14 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-04-04 05:29:03 PDT ---
(In reply to comment #12)
> Then WockyDataForm should be fixed to give you the actual values.

I've done something which fixes this, although perhaps not the best way ever?
Thoughts?

(In reply to comment #13)
> I wouldn't do this like this. I'd make the loop that iterates the forms keep a
> set of FORM_TYPEs that it has already seen. Given that that loop already has
> code to bail out if the FORM_TYPE is missing, I don't see why this related
> validation happens ahead of time.

Okay, it now does the checking during.

Branch updated.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list