[Bug 34932] Use WockyMetaPorter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34932

--- Comment #13 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-04-05 01:45:49 PDT ---
(In reply to comment #11)
> I think invite_stanza_callback in the MUC manager should return TRUE in all
> cases: a malformed clique invite is still a clique invite. Otherwise we'll fall
> back to showing the text of the <body/>.

Done.

> nice indentation, bro.

Fixed.

> and this is I think existing code, but while you're here you could replace
> this:
> 
>   wocky_stanza_get_type_info (reply, NULL, &sub_type);
> 
>   if (sub_type == WOCKY_STANZA_SUB_TYPE_ERROR)
>     {
>       wocky_stanza_extract_errors (reply, NULL, &error, NULL, NULL);
>       goto out;
>     }
> 
> with this:
> 
>   if (wocky_stanza_extract_errors (reply, NULL, &error, NULL, NULL))
>     goto out;

OK.

> So, fix the clique invite handler, fix the indentation (and if you're keen the
> sub_type stuff), and merge away!

Fuck yeah!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.