[Bug 35341] Use Connection.Interface.ContactBlocking in Tp::ContactManager

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35341

--- Comment #7 from Olli Salli <ollisal at gmail.com> 2011-04-05 07:19:21 PDT ---
(In reply to comment #4)
> Andre further updated the branch. Some quick review comments:
> 
> 
> +    PendingOperation *blockContacts(const QList<ContactPtr> &contacts, bool
> value, bool reportAbuse);
> 
> I find a single method called "block" the "value" param of which changes it to
> actually unblock exceedingly confusing, especially considering the reportAbuse
> parameter doesn't make sense with "value = false".
> 
> So separate to blockContacts and unblockContacts, please.
> 

I see we already have similarly crappy API without the report abuse param.
Please deprecate that, and have blockContacts(contacts, reportAbuse) and
unblockContacts().

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.