[Bug 27459] implement a fast-path for Connection properties from spec 0.19.2

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27459

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-11 06:26:17 PDT ---
http://git.collabora.co.uk/?p=user/oggis/telepathy-glib.git;a=commitdiff;h=f4514c86c30c2cfa5a18de84918af5c8079a96c6

Doesn't TpDBusPropertiesMixin crash (or at least critical) if getting the
GObject property fails?

http://git.collabora.co.uk/?p=user/oggis/telepathy-glib.git;a=commitdiff;h=222bfe4ee068d08c633457906610299f4c2d8eba

I think I'd split the grabbing-things-from-properties block into its own
function, so that you can just return FALSE; when things go awry; this gets rid
of the goto and would make it easier to skim-read.

Test-wise, I guess that the existing tests implicitly exercise the new code
paths, and the tests where you've deliberately broken the properties test the
fallback?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.