[Bug 34796] Implement ContactInfo

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 11 17:48:43 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #22 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-11 08:48:43 PDT ---
(In reply to comment #18)
> On the other hand, this ERR_NOSUCHSERVER is an exception in the sense that all
> the other numeric replies to a WHOIS will have a handle as the first element.
> So by passing the whole GValueArray we can avoid having the following statement
> repeated in all the handlers:
>     TpHandle handle = g_value_get_uint(g_value_array_get_nth(args, 0));

You're right; I think faking up the GValueArray is arguably neater. :)

I've merged these four patches:
<http://cgit.freedesktop.org/telepathy/telepathy-idle/log/?id=5c3672d0d66eb9f51ef1c86d287d637b5d9f69d9>.

As discussed on IRC, it would be good to handle RPL_TRYAGAIN by returning an
error (such as ServiceBusy) from RequestContactInfo.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list