[Bug 27459] implement a fast-path for Connection properties from spec 0.19.2

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27459

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Olli Salli <ollisal at gmail.com> 2011-04-12 03:38:07 PDT ---
(In reply to comment #7)
> + * Declare that this proxy supports the given interfaces. Equivalent to
> calling
> + * g_quark_from_string () followed by tp_proxy_add_interface () for each of
> the
> + * interface names.
> 
> tp_proxy_add_interface() doesn't exist; you mean
> tp_proxy_add_interface_by_id().
> 

True! Fixed.

> This branch is going to fail make check with gtk-doc enabled, because you
> didn't add tp_proxy_add_interfaces to telepathy-glib-sections.txt.

Oh. I knew I had to have noobed something with gtk-doc. Fixed, and make check
with --enable-gtk-doc verified to pass.

> 
> I'd kind of expect tp_proxy_add_interfaces to early-return if interfaces ==
> NULL.

Fair enough. It does now.

> 
> Fix the above, and then merge the -0.14 variant to 0.14 please!

Thanks! Done. I leave the forward-porting runes to get it into master to you,
though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.