[Bug 36134] TpProtocol claims it doesn't support any extra iface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36134

--- Comment #11 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-12 06:27:27 PDT ---
Review of attachment 45524:
 --> (https://bugs.freedesktop.org/review?bug=36134&attachment=45524)

“More use tp_proxy_add_interfaces” isn't English.

“Use tp_proxy_add_interfaces() more [widely]” is.

::: telepathy-glib/account.c
@@ +469,2 @@
+  interfaces = tp_asv_get_boxed (properties, "Interfaces", G_TYPE_STRV);
+  tp_proxy_add_interfaces (proxy, interfaces);

This could even become

tp_proxy_add_interfaces (proxy, tp_asv_get_strv (properties, "Interfaces"));

::: telepathy-glib/connection-manager.c
@@ +708,2 @@
 tp_connection_manager_add_interfaces (TpConnectionManager *self,
     const gchar * const * interfaces)

This function doesn't do anything else, and isn't API, so just delete it?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.