[Bug 36058] Available presence seen for a bit when switching from dnd to away

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36058

--- Comment #4 from Marco Barisione <marco.barisione at collabora.co.uk> 2011-04-12 13:25:41 PDT ---
(In reply to comment #2)
> OHHHHHH! That's how it works. privacy_lists_loaded_cb() (the callback for 
>  get_existing_privacy_lists_async()) is called when receiving the privacy lists
> from the Google server fails (as it inevitably will), and that function calls
> toggle_presence_visibility_async(). And this works in the test suite because
> BaseXmlStream (and hence SharedStatusStream) responds to privacy list queries
> in the negative by default.

Oh, I thought conn_presence_set_initial_presence_async() was called.

> I don't suppose you fancy tidying that up so that Gabble doesn't

Can try, not sure the results will be good at the first attempt :) (and hey,
this code is entangled!)

> On presence/shared-status.py: test the correct behaviour with away and xa:
> 
> +    #e = q.expect('dbus-signal', signal='PresenceUpdate')
> +    #print e.args
> +    #return
> 
> O rly.

Ops, yes.

> +                     "chat"       : ['Please talk with me!',
> +                                     'Work is overrated, let\'s chat']}
> 
> I thought you said the 'chat' status stops working as a result of this branch;
> but your test tests it.

Yes, but look at presence_types: we expect PRESENCE_AVAILABLE when "chat" is
used. Of course this would need a comment.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.