[Bug 33054] Doesn't respect Google Shared Status status-max

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33054

Andre Moreira Magalhaes <andrunko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/
                   |                            |gitweb/?p=user/andrunko/tel
                   |                            |epathy-gabble.git;a=shortlo
                   |                            |g;h=refs/heads/presence-sta
                   |                            |tus-max
           Keywords|                            |patch

--- Comment #2 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-04-14 06:39:15 PDT ---
So here goes the status:

- The following branches are ready for review:
tp-spec -
http://git.collabora.co.uk/gitweb/?p=user/andrunko/telepathy-spec.git;a=shortlog;h=refs/heads/presence-status-max
tp-glib -
http://git.collabora.co.uk/gitweb/?p=user/andrunko/telepathy-glib.git;a=shortlog;h=refs/heads/presence-status-max
tp-gabble -
http://git.collabora.co.uk/gitweb/?p=user/andrunko/telepathy-gabble.git;a=shortlog;h=refs/heads/presence-status-max
tp-qt4 -
http://git.collabora.co.uk/gitweb/?p=user/andrunko/telepathy-qt4.git;a=shortlog;h=refs/heads/presence-status-max

Some notes about the impl:
- The new property is called Conn.SimplePresence.MaximumStatusMessageLength.
  I chose this name as MaximumMessageLength seems vague to me.
- The tp-glib impl adds a new callback to PresenceMixin. This callback ideally
would be set in presence_mixin_class_init but we can't change its signature
without breaking API, so I just added the callback and set it after calling
class_init on gabble/test CM/etc.
- The tp-glib version has a copy of the new interface Conn.SimplePresence as
tp-glib requires it in order to access a property. Properties not generated
from the interface cannot be used.
- The tp-qt4 impl do not have a copy of the new interface as we don't require
it, I just implemented the support internally.
- Updated tp-glib contacts-conn to support the new property and copied an
updated version of it to tp-qt4 (to properly test the support). 
- The docs for the new property in the spec probably needs some love.

Missing (how to proceed?):
- gabble and tp-qt4 (new tests) should update the tp-glib dependency to a
proper tp-glib version once released.
- tp-glib should probably update to spec-0.22.2 once available instead of
having a copy of the new interface only (not sure how this works exactly in
tp-glib)
- tp-qt4 should update to spec-0.22.2 once available (not sure if this is a
requirement but it would be good at least). I have a bitrotting branch to
update to 0.22.0, which we should probably update and use it once the new spec
is released.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.