[Bug 35205] Support PEP

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35205

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-14 11:00:10 PDT ---
im-manager: only deal with messages for this manager
We only like no subtype and subtype="chat" messages.

+  wocky_stanza_get_type_info (stanza, NULL, &sub_type);
+
+  /* we only handle messages without a sub type here */
+  if (sub_type != WOCKY_STANZA_SUB_TYPE_NONE
+      && sub_type != WOCKY_STANZA_SUB_TYPE_CHAT)
+    return FALSE;

the commit message, comment and code don't agree.

Also, what about type='error'? and type='headline'? They're perfectly
reasonable types for messages. I think this is secret code for using a
higher-priority handler for pubsub event messages, maybe?

Why does salut_send_ll_pep_event() have two different local variables for the
contact factory?

You could extract send_ll_pep_event_to_contact (WockyLLContact *, WockyStanza
*) to reduce the code duplication between the loop and the self-contact blocks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.