[Bug 35884] Add support for delivery report into TpMessage

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35884

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-04-18 06:55:05 PDT ---
Right, I've replied a little too quickly.

(In reply to comment #3)
> http://telepathy.freedesktop.org/spec/Channel_Interface_Messages.html#Simple-Type:Delivery_Report_Header_Key
> 
> What do you think about this API:
> 
> I think it's good to have a common tp_message_delivery_report_* prefix for
> these functions.
> 
> TpDeliveryStatus tp_message_delivery_report_get_status (TpMessage *self,
>     GError **error);
> 
> The error will be constructed using tp_proxy_dbus_error_to_gerror() with
> the "delivery-dbus-error" and "delivery-error-message" keys.
> I'm sure if this should be part of get_status() or not.

Maybe the gerror should be retrieved along with the send error instead ?

> 
> const gchar * tp_message_delivery_report_get_token (TpMessage *self);
This one we need for sure.

> TpChannelTextSendError tp_message_delivery_report_get_send_error (
>     TpMessage *self);
It's a little weird to have this one separated from the GError. Thinking of it,
'm wondering if the GError is not more related to the send error then it is
from the status ?

> 
> TpMessage * tp_message_delivery_report_dup_echo (TpMessage *self);
> 
> It's a _dup and not a _get as it will have to create a new object.
Not sure this one will be used in the logger, but I guess it could be handy at
some point.

> 
> 
> TpContact * tp_message_delivery_report_get_sender (TpMessage *self);
> I find 'sender' a bit confusing but that's what's used in the spec...

Yes it is, maybe we could find something better.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.