[Bug 28918] NewChannels fired twice when connecting to a bip account

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28918

--- Comment #3 from Debarshi Ray <debarshi.ray at gmail.com> 2011-04-18 13:58:01 PDT ---
(In reply to comment #2)

> Basically whenever a JOIN message is received for a channel that you did not
> attempt to join yourself.

Oops, sorry! What was I thinking? Here is the correct analysis.

Whenever we try to handle an INVITE or a JOIN for which there is no channel, we
do (as Guillaume wrote):
+ _muc_manager_new_channel
+ tp_channel_manager_emit_new_channel (emits NewChannels)

After that, in case of JOIN, irrespective of whether there was a channel or
not, we do:
+ idle_muc_channel_join (emits NewChannels)

And in case of INVITE, we try a normal join operation if the user wants to,
which leads to a NewChannels as well.

I am not sure about the behaviour in case of an INVITE, but for the
_join_handler, the easy way out is to not call
tp_channel_manager_emit_new_channel.

However, I am told that older versions of Bitlbee
(http://www.bitlbee.org/main.php/news.r.html) does not want the client to leave
the &bitlbee channel and sends a JOIN to the client whenever it does so. I
don't know if this is a correct use of JOIN and since newer Bitlbee versions
don't do so, I am not sure if we should support this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.