[Bug 35058] Should send keep-alive packets to detect dropped connections.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35058

--- Comment #4 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-04-18 18:10:15 PDT ---
Review of attachment 45704:
 --> (https://bugs.freedesktop.org/review?bug=35058&attachment=45704)

::: src/idle-connection.c
@@ +24,3 @@
 #include <config.h>

+#include <inttypes.h>

Unneeded, see below.

@@ +753,3 @@
 }

+static void _send_with_priority(IdleConnection *conn, const gchar *msg, guint
priority);

I don't think this should be in the middle of the file. Put it at the top.

@@ +767,3 @@
+
+    ping_time = g_get_real_time();
+    gint64 ping_time;

Use G_GINT64_FORMAT instead of PRId64

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.