[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #31 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-29 05:33:32 PDT ---
Review of attachment 46064:
 --> (https://bugs.freedesktop.org/review?bug=34796&attachment=46064)

Looks functionally fine, though I have a couple of nitpicks :)

::: src/idle-contact-info.c
@@ +256,3 @@
+    command = g_ascii_strup(g_value_get_string(g_value_array_get_nth(args,
0)), -1);
+    if (g_strcmp0(command, "WHOIS"))
+     * WHOIS. So we assume that the last WHOIS request that we had issued has
resulted in this RPL_TRYAGAIN. This is fine as long nobody else is

You can use g_ascii_strcasecmp() to avoid having to uppercase the string, which
avoids needing the goto cleanup.

@@ +262,3 @@
+    msg = g_value_get_string(g_value_array_get_nth(args, 1));
+
+

g_error_new_literal().

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.