[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #34 from Will Thompson <will.thompson at collabora.co.uk> 2011-04-29 05:45:22 PDT ---
Review of attachment 46067:
 --> (https://bugs.freedesktop.org/review?bug=34796&attachment=46067)

Just some tiny nitpicks:

::: tests/twisted/messages/contactinfo-request.py
@@ +15,3 @@
+    for (name, parameters, value) in vcard:
+        if name == 'fn':
+            assert value[0] == 'Test User'

Does servicetest.py in Idle have the assertEquals() etc. family of functions
that are included in Gabble's version of servicetest.py? If not, okay, but
maybe in the future Idle's copy could be refreshed.

@@ +39,3 @@
+    call_async(q, conn, 'GetSelfHandle')
+    event = q.expect('dbus-return', method='GetSelfHandle')
+    self_handle = event.value[0]

You can spell this as self_handle = conn.GetSelfHandle()

@@ +51,3 @@
+    call_async(q, contact_info, 'RequestContactInfo', self_handle)
+    event = q.expect('dbus-error', method='RequestContactInfo')
+    assert event.name == SERVICE_BUSY

Maybe you could comment this to explain that the test server alternates success
and failure?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.