[Bug 33460] IM and MUC channels should use wocky_porter_send_async(), and emit failing delivery reports

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33460

Siraj Razick <siraj.razick at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://cgit.collabora.co.uk |http://cgit.collabora.co.uk
                   |/git/user/siraj/telepathy-g |/git/user/siraj/telepathy-g
                   |abble.git/commit/?h=error_r |abble.git/commit/?h=error_r
                   |eports&id=44978825ef085ad2f |eports
                   |2d93ad7f9438ab2a6c6b565     |

--- Comment #5 from Siraj Razick <siraj.razick at collabora.co.uk> 2011-04-29 06:51:04 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > You're not meant to send failed delivery reports for messages that you haven't
> > signalled as being set.
> 
> Sorry, that was meant to be: "... signalled as being *sent*". Hopefully less
> confusing now :-)
> 
> You're also missing a regression test for any of this (although I realise it
> might be hard to write one, because you have little control over how fast the
> message gets through to the socket). Have you done manual testing?

Yeah I asked about doing a test case on irc some days back when I started with
the patch.. every one told it's hard so yes i did manual testing, but only for
im channel..etc 

I'll modify the patch according to the review comments and test again.

thank you for the good/informative review :),  that's why i called it the
initial :D... I'll continue and submit a new patch :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.