[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #36 from Debarshi Ray <debarshi.ray at gmail.com> 2011-04-29 09:55:00 PDT ---
(In reply to comment #31)
> Review of attachment 46064 [details]:
> 
> Looks functionally fine, though I have a couple of nitpicks :)
> 
> ::: src/idle-contact-info.c
> @@ +256,3 @@
> +    command = g_ascii_strup(g_value_get_string(g_value_array_get_nth(args,
> 0)), -1);
> +    if (g_strcmp0(command, "WHOIS"))
> +     * WHOIS. So we assume that the last WHOIS request that we had issued has
> resulted in this RPL_TRYAGAIN. This is fine as long nobody else is
> 
> You can use g_ascii_strcasecmp() to avoid having to uppercase the string, which
> avoids needing the goto cleanup.

Fixed.

> @@ +262,3 @@
> +    msg = g_value_get_string(g_value_array_get_nth(args, 1));
> +
> +
> 
> g_error_new_literal().

Fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.