[Bug 26205] High-level API for ContactLists

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26205

--- Comment #61 from Xavier Claessens <xclaesse at gmail.com> 2011-08-05 02:21:10 PDT ---
(In reply to comment #59)
> (In reply to comment #48)
> > Review of attachment 49907 [details] [details]:
> > 
> > ::: telepathy-glib/account-manager.c
> > @@ +63,3 @@
> > + * #TpAccountManager is the "top level" object, its #TpProxy:factory will be
> > + * propagated to all other objects like #TpAccountManager -> #TpAccount ->
> > + * #TpConnection -> #TpContact and #TpChannel.
> > 
> > I'd make clearer that imply all the features from this factory will be
> > prepared.
> 
> You didn't fix this one.

Right, added "This means that desired features
 * set on that factory will be prepared on all those objects."

> 
> (In reply to comment #54)
> > Review of attachment 49905 [details] [details]:
> > @@ +709,3 @@
> > + * For this method to be valid, you must first call tp_proxy_prepare_async()
> > + * with the feature %TP_CONNECTION_FEATURE_CONTACT_LIST and verify the
> > + * #TpConnection:contact-list-state is set to %TP_CONTACT_LIST_STATE_SUCCESS.
> > 
> > if state is not SUCCESS, even if feature is prepared, returned list will be
> > empty. Feature being prepared means "we know CM's state" but does not mean the
> > CM already fetched from server. Doc could be improved I guess...
> 
> Then the doc of the feature lies:
> "When this feature is prepared (...) all #TpContact objects has been prepared
> with the desired features"

right, fixed the doc to say this apply only if contact-list-state is SUCCESS.

> Also the examples are wrong as they assumed that once the feature has been
> prepared the list of contacts is ready to be used.

if state is not success, the list of contacts would just be empty. But to be
more demonstrative, I added a check that state is SUCCESS.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.