[Bug 42095] New: Drop support for legacy interfaces where it does not break ABI

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Dec 1 14:42:52 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=42095

             Bug #: 42095
           Summary: Drop support for legacy interfaces where it does not
                    break ABI
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
               URL: http://cgit.collabora.com/git/user/xclaesse/telepathy-
                    glib.git/log/?h=cleanup
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: xclaesse at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.collabora.com/g
                   |                            |it/user/xclaesse/telepathy-
                   |                            |glib.git/log/?h=cleanup
           Keywords|                            |patch

We have lots of fallback code that none of our CMs needs anymore. For example
contact attributes and dbus properties should be mandatory everywhere now IMO.

Since we released 0.16.0 stable branch, now is a good time to remove a bit of
legacy code and raise the minimum expected from our CMs, IMO. That would make
this more maintainable, I think.

--- Comment #1 from Xavier Claessens <xclaesse at gmail.com> 2011-10-21 09:54:00 PDT ---
Here is a branch already removing ~3500 lines of code:

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=cleanup

--- Comment #2 from Xavier Claessens <xclaesse at gmail.com> 2011-10-21 09:56:52 PDT ---
Could also remove fallback in TpChannel and make properties mandatory there.
But there were recent spec changes there that are not yet in tp-python...

--- Comment #3 from Xavier Claessens <xclaesse at gmail.com> 2011-12-01 05:42:52 PST ---
The branch now makes properties mandatory for CORE and GROUP features of
TpChannel. It also makes MembersChangedDetailed mandatory (otherwise, TpChannel
fails to prepare). Those are supported by all CMs as far as I know.

I'm pondering making TpConnection fail to prepare if it does not have immortal
handles, but that would make definitely break python CMs, right?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list