[Bug 43239] Tp::SharedPtr tries to be thread-safe, but secretly isn't

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43239

--- Comment #7 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-12-05 07:50:30 PST ---
(In reply to comment #5)
> 1) make WeakPtr constructible from raw pointer, if there isn't some issue I'm
> overlooking, and use it wherever sensible
Added

> 2) explain in the docs, NEWS API changes section and commit message why
> promotion from QWeakPointer is gone
Done in the docs (NEWS will be updated when merging), but I am not really happy
with this, suggestions are welcome.

> 3) ponder making SharedCount more of an internal implementation detail
> (compiler checkably) than a public class, because we *can* if my memory serves
> me correctly on the template <class X...> friend class Y; syntax
Done

> 4) adjust tests
Done

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.