[Bug 41356] No method to retrieve available message types [patch]

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41356

--- Comment #6 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-12-05 09:06:18 PST ---
Here is a review for the Dario's branch:

+ * This method requires TextChannel::FeatureMessageCapabilities to be ready.
+ *
+ * \return The list of supported message types
+ */
+QList<ChannelTextMessageType> TextChannel::supportedMessageTypes() const
+{
+ if (!isReady(FeatureCore)) {
You should be checking for FeatureMessageCapabilities here.

bool TextChannel::supportsMessageType(ChannelTextMessageType messageType) const
{
+ if (!isReady(FeatureCore)) {
Same here

+ QVERIFY(mChan->supportsMessageType(static_cast<ChannelTextMessageType>(0U)));
Please add checks for supported and unsupported, also please use enums instead
of "0U" here.

+ Q_FOREACH (uint messageType, messageTypesAsUIntList) {
Use foreach, emit, etc for internal code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.