[Bug 42095] Drop support for legacy interfaces where it does not break ABI

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42095

--- Comment #5 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-12-13 04:30:00 PST ---
+ if (!tp_proxy_has_interface_by_id (context->connection,
+ TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACTS))
+ {
+ GError *error = g_error_new_literal (TP_ERRORS,
+ TP_ERROR_SOFTWARE_UPGRADE_REQUIRED,
+ "Connection does not implement CONTACTS interface. Legacy CM "
+ "are not supported anymore");
+
+ WARNING ("%s", error->message);
+ contacts_context_fail (context, error);
+ g_clear_error (&error);
+ }


(Thanks Firefox or whoever for removing indentation.)

Should this not return from the function after g_clear_error?

Also, "CMs" please.

  PROP_ACCOUNT = 1,
- PROP_BREAK_PROPS = 2,
  PROP_DBUS_STATUS = 3,
  N_PROPS

Probably not a problem, but still.

+ * return FALSE will invalidate the proxy. */

"returning FALSE" (sorry for the nit-pick)

Other than these, this branch looks fine. I assume the tests all pass again
given your work on them?

I'm just thinking about where this branch should end up, master or next.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.