[Bug 43598] Add high-level API for Proto.I.Addressing interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43598

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-12-15 03:17:52 PST ---
(In reply to comment #5)
> I tried adding some members to ExampleEcho2Protocol

Please do things like this in a subclass (or fork it and rename it,
InstrumentedProtocol or something); ExampleEcho2Protocol is meant to be a
simple example for CM authors, and if it contains this sort of instrumentation,
it's no longer a good example. (Yes, I still think files that also exist in
tp-glib should be in sync.)

It sounds as though you actually need at least three TpBaseProtocol subclasses:
one with a full .manager file, one with a partial .manager file and one with no
.manager file at all.

> The problem is that we
> inherit TpBaseProtocol that only expose some methods for introspection, and
> some of these methods are called in the constructor of TpBaseProtocol among
> others. So I can't reliably check the counters.

I can see two ways round this, neither of which is suitable to appear in an
example:

* put conflicting information in the manager file and the code, so you can
  always tell where it came from; in the "partial manager file" case,
  accept either version

* override and reimplement the D-Bus interface (i.e. don't use
  TpBaseProtocol's implementation)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.