[Bug 43986] Wocky fails to cross compile with mingw32

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43986

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-12-22 05:44:38 PST ---
(In reply to comment #3)
> Patch is updated as a single commit in a new branch mingw32 now.

Actually I did mean that you should use #ifdef G_OS_WIN32 ... #else ... #endif
with the linux stuff in the #else as these are mutually exclusive, so instead
of:

> +#include <config.h>
> +
> +#ifdef HAVE_SYS_SOCKET_H
>  #include <sys/socket.h>
>  #include <netinet/in.h>
>  #include <arpa/inet.h>
> +#endif
> +
> +#ifdef G_OS_WIN32
> +#include <windows.h>
> +#include <ws2tcpip.h>
> +#endif

this:

#include <config.h>

#ifdef G_OS_WIN32
#include <windows.h>
#include <ws2tcpip.h>
#else
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#endif

We've already depended on these header files being present so I think it's fine
to assume they're there without the #ifdef HAVE_SYS_SOCKET_H.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.