[Bug 43025] Add setStatusMessage(QString) to Tp::Presence
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Dec 30 19:41:48 CET 2011
https://bugs.freedesktop.org/show_bug.cgi?id=43025
Olli Salli <ollisal at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
AssignedTo|telepathy-bugs at lists.freede |martin.klapetek at gmail.com
|sktop.org |
--- Comment #3 from Olli Salli <ollisal at gmail.com> 2011-12-30 10:41:48 PST ---
The patch is fine. I was about to comment about missing documentation... but
there is no documentation for anything in Tp::Presence.
So, now we have:
setStatus(type, status, message) // sets all
setStatusMessage(message) // keeps the current status
I think this is exactly what we should have. The type and status can't be
sensibly set separately, because they are tied together. Also, whether a
message can be set depends on the status in many protocols, so if you change
the status, the message can't necessarily stay the same.
I've added a TODO note to explain this when the class in general is documented
properly... and merged your patch to master. Will be in tp-qt-0.9.1.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list