[Bug 28287] ContactInfoChanged is emitted 2 times in response to RefreshContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28287

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ish

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-02 08:28:55 PST ---
+    # ContactInfoChanged should not be signalled again
+    forbidden = [EventPattern('dbus-signal', signal='ContactInfoChanged')]
+    q.forbid_events(forbidden)
+
     # Refresh the contact info again; gabble should contact the server again
     call_async(q, conn.ContactInfo, 'RefreshContactInfo', [handle])

     event = q.expect('stream-iq', to='bob at foo.com', query_ns='vcard-temp',
         query_name='vCard')

+    sync_dbus(bus, q, conn)
+
+    q.unforbid_events(forbidden)


I think you can put the sync_dbus() call and unforbid thing above the
call_async, no?

But it basically looks fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.