[Bug 33660] Add tp_debug_sender_is_enabled()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33660

--- Comment #5 from Vivek Dasmohapatra <vivek at collabora.co.uk> 2011-02-08 08:47:04 PST ---
> function name suggestions, add_message_vprintf and add_message_printf.
Will rename then, I guess.

> +#ifndef ENABLE_DEBUG_CACHE
> +  if (self->priv->enabled || formatted != NULL)
> +    {
> +#endif
> 
> Instead of indenting the whole function couldn't you do:

Done. the code there used to be a little different, the 
enclosing {} made sense before, but it's superfluous now.

> +      if ((when = timestamp) == NULL)
> Can we just split this into two lines please?

done.

> + * formats and adds a new message to the debug sender message queue. If the
> Capital F!

Done.

> + * @timestamp: Time of the message, or %NULL for right now
> 
> Just out of interest, why is this different from _add_message in that it

add_message didn't have a fallback before, for no really good reason except
that was how it was written. They all fall back now.


> + * Since: UNRELEASED
> Usual style is major.minor.UNRELEASED but it doesn't really matter as it's
> going to get sedded out later anyway.

> You haven't added the new functions to the gtk-doc sections file so I'm
> guessing you haven't run make check or distcheck?

check passes.
distcheck fails in a completely unrelated file that I haven't even gone near.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.